Skip to content
Chernabog

address-review

Terminal window
chernabog recipes add address-review

Bakes .chernabog/flows/address-review.ts. Its prompts, consider and address, are the SDK’s own unless the repo adds .chernabog/prompts/consider.md or address.md.

Picks up an open pull request the persona wrote whose latest decisive review, an approval or a request for changes (comments don’t count), requests changes on the current head, so nothing has been pushed since. It leaves alone a pull request labelled auto:needs-human or owned by another flow’s run. The trigger checks the persona’s own login, and the flow sets ownWork: true.

Ends with a green push and the reviewer asked again, which starts their re-review, or the pull request handed to a person with auto:needs-human.

Its steps

Section titled “Its steps”
  1. Review.changesAsked and Review.authorSession — the review, and the session that implemented the pull request, from the session marker implement left.
  2. Review.prepareAuthorWorktree — the author’s worktree, brought up to date.
  3. Implement.considerFindings — resumes that session and asks whether to address the findings:
    • Disagree. It posts “Not addressing review N:” with its reasons and hands the pull request to a person. It doesn’t push, and doesn’t ask the reviewer again.
    • Agree. Implement.addressFindings makes and commits the changes.
  4. Review.checkChanged, Implement.localGate, Implement.push and Implement.waitForCi — checks something was committed and nothing was left uncommitted, runs the local gate, pushes, and waits for CI, fixing red up to ciRounds.
  5. Review.askAgain — comments “Addressed review N:” with what changed and asks the reviewer who requested the changes to review again.

On a pull request from the hybrid path, the session marker says a person worked in the session, so address-review reopens it in front of them: the person and the agent weigh the review, make the changes, and fix the local gate and CI there, together. Its push passes { withPerson: session.withPerson }, so a fix that touches humanOnlyPaths pushes on that pull request, and goes to a person on one an unattended run opened. See Trust.

Anything else that stops it, such as CI still red, a failing local gate, the agent needing an answer, or a failed step, hands the pull request to a person with auto:needs-human. A person settles a dispute, removes the label, and asks the reviewer again if it should look again.